Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/docusaurus-theme-mermaid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
"@docusaurus/theme-common": "3.9.2",
"@docusaurus/types": "3.9.2",
"@docusaurus/utils-validation": "3.9.2",
"mermaid": ">=11.6.0",
"mermaid": ">=11.13.0",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this needs to be bumped. People can already use newer versions

"tslib": "^2.6.0"
},
"devDependencies": {},
"peerDependencies": {
"@mermaid-js/layout-elk": "^0.1.9",
"@mermaid-js/layout-elk": "^0.2.1",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, a 0.x minor semver version can ship breaking changes, although this one doesn't ship any problematic change IMHO.
https://github.com/mermaid-js/mermaid/blob/develop/packages/mermaid-layout-elk/CHANGELOG.md#020

It's not super clear if MermaidJS commits to respecting semver because they sometimes kind-of break things in releases that shouldn't be breaking.

Since it's a peer dependency, I guess we could just use >=0.1.9 (we already use >= for mermaid anyway) and let users choose the version they want.

"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
Expand Down
Loading