Support STAGED->RUNNING transitions in _apply_trial_statuses#5214
Closed
yangjoanna wants to merge 1 commit into
Closed
Support STAGED->RUNNING transitions in _apply_trial_statuses#5214yangjoanna wants to merge 1 commit into
yangjoanna wants to merge 1 commit into
Conversation
Summary: The Orchestrator skipped all `is_deployed` statuses (STAGED and RUNNING) in `_apply_trial_statuses`, so trials with `staging_required=True` could never transition from STAGED to RUNNING through the polling path. This fixes that by processing actual status changes (e.g. STAGED->RUNNING) while still skipping no-ops (RUNNING->RUNNING). Also adds a `started_time` parameter to `mark_running()` so runners can provide the actual deployment timestamp instead of defaulting to `datetime.now()`. The Orchestrator reads `time_started` from `run_metadata` and passes it through on transition. Reviewed By: saitcakmak Differential Revision: D106868394
meta-cla
Bot
added
the
CLA Signed
|
@yangjoanna has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106868394. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5214 +/- ##
==========================================
- Coverage 96.51% 96.50% -0.01%
==========================================
Files 617 617
Lines 69694 69776 +82
==========================================
+ Hits 67262 67339 +77
- Misses 2432 2437 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 8749b08. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Orchestrator skipped all
is_deployedstatuses (STAGED and RUNNING) in_apply_trial_statuses, so trials withstaging_required=Truecould never transition from STAGED to RUNNING through the polling path. This fixes that by processing actual status changes (e.g. STAGED->RUNNING) while still skipping no-ops (RUNNING->RUNNING).Also adds a
started_timeparameter tomark_running()so runners can provide the actual deployment timestamp instead of defaulting todatetime.now(). The Orchestrator readstime_startedfromrun_metadataand passes it through on transition.Reviewed By: saitcakmak
Differential Revision: D106868394