Comms flood protection, Dockerfile layer-cache optimisation & dependency bumps#43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds flood-protection to the communications background service, optimises the Docker build layer caching, refreshes NuGet dependencies, and tidies up build/CI tooling and instructions.
Changes
Communications service — flood protection
Adds producer-flood protection to
CommunicationsBgServiceso a burst of stream events can no longer be drip-fed to the Signal group over hours.StreamSendThrottle) gates producer-driven stream events before the agent runs — suppressed events are acknowledged but dropped, and inference is skipped for them. Interactive replies to user messages are never throttled.MaxEventAgeSecondsare acknowledged but dropped instead of delivered late.DropOldest) capped atReplyQueueCapacity, so a flood cannot grow an unbounded backlog.DropNoticeIntervalMs) is sent to the group summarising how many rate-limited / stale notifications were dropped; the first drop emits immediately.LoggerMessagesource-gen entries for suppressed / stale / drop-notice events.CommsAgentConfigoptions (all with sensible defaults and[Range]validation):StreamSendThrottlingEnabled,StreamSendRatePerMinute,StreamSendBurst,StaleEventDroppingEnabled,MaxEventAgeSeconds,DropNoticeIntervalMs,ReplyQueueCapacity.Docker build
# syntax=docker/dockerfile:1) and replace the long hand-maintained per-projectCOPYlist withCOPY --parents src/**/*.csproj ./, so editing source files reuses the cached restore layer.ARG TARGETPLATFORMso the platform-agnostic restore layer is shared across architectures.Dockerfile.Debuguses the/./pivot to land the siblingdeps/repos at the filesystem root and restores manifests only before copying source..dockerignoreoverhaul: broaden props/targets allow-list (!**/*.props,!**/*.targets), include the fulldeps/**tree for Debug builds, and explicitly excludebin/obj/.git/.vs,appsettings.Local*.json, and**/*.Teststo keep the build context lean and avoid cache busts.Dependencies
CasCap.Common.*4.12.1 → 4.12.2CasCap.Api.Azure.*1.5.0 → 1.5.1Spectre.Console*0.57.0 → 0.57.1Swashbuckle.AspNetCore10.2.1 → 10.2.3Microsoft.NET.Test.Sdk18.6.0 → 18.7.0CI / tooling
package-cleanup.ymlworkflow (committed commented-out) wired tof2calv/gha-workflowsfor scheduled GHCR image pruning, withdry-rundefaulted on until validated.actions/checkoutv6 → v7 in_gitops-helm-update.ymlandcopilot-setup-steps.yml..copilot-tracking/runtime artefacts in.gitignore.Documentation
Foo{T}.cs),IOptions<T>access, and parameter-wrapping conventions incsharp.instructions.md.Notes
CommsAgentConfig.appsettingschanges are required to adopt.