Skip to content

return error on non-string element in join #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netliomax25-code wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

return error on non-string element in join #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion builtin/builtin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,11 @@ var Builtins = []*Function{
case []any:
var s []string
for _, arg := range args[0].([]any) {
s = append(s, arg.(string))
str, ok := arg.(string)
if !ok {
return nil, fmt.Errorf("invalid argument for join (type %s)", reflect.TypeOf(arg))
}
s = append(s, str)
}
return strings.Join(s, glue), nil
}
Expand Down
1 change: 1 addition & 0 deletions builtin/builtin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ func TestBuiltin_errors(t *testing.T) {
{`now(nil)`, "invalid number of arguments (expected 0, got 1)"},
{`date(nil)`, "interface {} is nil, not string (1:1)"},
{`timezone(nil)`, "cannot use nil as argument (type string) to call timezone (1:10)"},
{`join([1, 2])`, "invalid argument for join (type int)"},
{`flatten([1, 2], [3, 4])`, "invalid number of arguments (expected 1, got 2)"},
{`flatten(1)`, "cannot flatten int"},
{`fromJSON("5e2482")`, "cannot unmarshal number"},
Expand Down