[eas-cli] add --build-number to observe:metrics and observe:events - #4278
Open
kadikraman wants to merge 2 commits into
Open
[eas-cli] add --build-number to observe:metrics and observe:events#4278kadikraman wants to merge 2 commits into
kadikraman wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## kadikraman/add-apple-platform #4278 +/- ##
=================================================================
+ Coverage 64.06% 64.06% +0.01%
=================================================================
Files 1042 1042
Lines 48019 48022 +3
Branches 10136 10138 +2
=================================================================
+ Hits 30757 30760 +3
Misses 17146 17146
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
kadikraman
marked this pull request as ready for review
August 25, 2026 17:31
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Resolves ENG-26159.
We were missing a
--build-numberfilter from metrics and events.How
build-numberflag to the shared observe flags.observe:metricsandobserve:eventsTest Plan
Unit tests.
Metrics
Events