[eas-cli] Fail fast in deploy when a Free-plan deployment exceeds the Hosting limit - #4271
Closed
douglowder wants to merge 1 commit into
Closed
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
douglowder
force-pushed
the
doug/eng-26150-eas-cli-eas-deploy-should-fail-fast-when-plan-limits
branch
from
August 24, 2026 21:00
53f6509 to
edbae3c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4271 +/- ##
==========================================
- Coverage 64.05% 64.02% -0.02%
==========================================
Files 1042 1042
Lines 48009 48034 +25
Branches 10130 10136 +6
==========================================
+ Hits 30745 30750 +5
- Misses 17148 17168 +20
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… Hosting limit A Free-plan `eas deploy` for a site larger than the 1 GB EAS Hosting limit only failed after packing and uploading the whole site (~30-40 min), with an opaque error. Estimate the deployment size from the collected assets before uploading; when it exceeds the limit, query the account plan and, for Free-plan accounts, either prompt to continue (interactive) or fail fast (non-interactive) with the estimate, the limit, and an upgrade link. On --dry-run, only warn, since it never uploads. The plan is queried only when the estimate is over the limit, so normal deploys are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
douglowder
force-pushed
the
doug/eng-26150-eas-cli-eas-deploy-should-fail-fast-when-plan-limits
branch
from
August 25, 2026 02:02
edbae3c to
cf63044
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas deploywould attempt to deploy a very large site, exceeding the limit for free users, without checking to see if the deployment was possible first.How
Add a size check in the command code. If the deployment size is going to exceed the limit, check if the account is on the free plan. If so, do one of the following:
Fixes #4257 .
Test Plan
Stack created with GitHub Stacks CLI • Give Feedback 💬