Skip to content

[eas-cli] Accept individual ASC API keys for submissions, guard provisioning - #4249

Draft
sswrk wants to merge 1 commit into
szymonswierk/eng-21475-graphql-apple-utils-optional-issuerfrom
szymonswierk/eng-21475-accept-individual-submission-keys
Draft

[eas-cli] Accept individual ASC API keys for submissions, guard provisioning#4249
sswrk wants to merge 1 commit into
szymonswierk/eng-21475-graphql-apple-utils-optional-issuerfrom
szymonswierk/eng-21475-accept-individual-submission-keys

Conversation

@sswrk

@sswrk sswrk commented Aug 21, 2026

Copy link
Copy Markdown
Member

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@linear-code

linear-code Bot commented Aug 21, 2026

Copy link
Copy Markdown

ENG-21475

@sswrk
sswrk force-pushed the szymonswierk/eng-21475-accept-individual-submission-keys branch from 206da2b to cc9d457 Compare August 21, 2026 17:17
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.67742% with 25 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (szymonswierk/eng-21475-graphql-apple-utils-optional-issuer@4c0e463). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...as-cli/src/credentials/ios/appstore/AppStoreApi.ts 0.00% 23 Missing ⚠️
packages/eas-cli/src/integrations/asc/ascApiKey.ts 0.00% 1 Missing ⚠️
...ackages/eas-cli/src/submit/ios/IosSubmitCommand.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                                      Coverage Diff                                      @@
##             szymonswierk/eng-21475-graphql-apple-utils-optional-issuer    #4249   +/-   ##
=============================================================================================
  Coverage                                                              ?   63.82%           
=============================================================================================
  Files                                                                 ?     1030           
  Lines                                                                 ?    47518           
  Branches                                                              ?    10009           
=============================================================================================
  Hits                                                                  ?    30325           
  Misses                                                                ?    17093           
  Partials                                                              ?      100           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant