Skip to content

[build-tools] Support individual ASC API keys in upload_to_asc - #4247

Draft
sswrk wants to merge 1 commit into
mainfrom
szymonswierk/eng-21475-build-tools-upload-to-asc-individual-keys
Draft

[build-tools] Support individual ASC API keys in upload_to_asc#4247
sswrk wants to merge 1 commit into
mainfrom
szymonswierk/eng-21475-build-tools-upload-to-asc-individual-keys

Conversation

@sswrk

@sswrk sswrk commented Aug 21, 2026

Copy link
Copy Markdown
Member

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@linear-code

linear-code Bot commented Aug 21, 2026

Copy link
Copy Markdown

ENG-21475

@sswrk
sswrk force-pushed the szymonswierk/eng-21475-build-tools-upload-to-asc-individual-keys branch from 691fdf7 to d5e280f Compare August 21, 2026 17:17
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.75%. Comparing base (3f8ffac) to head (d5e280f).

Files with missing lines Patch % Lines
...ges/build-tools/src/steps/functions/uploadToAsc.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4247      +/-   ##
==========================================
+ Coverage   63.74%   63.75%   +0.01%     
==========================================
  Files        1030     1030              
  Lines       47477    47482       +5     
  Branches     9990     9992       +2     
==========================================
+ Hits        30260    30267       +7     
+ Misses      17116    17114       -2     
  Partials      101      101              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant