-
Notifications
You must be signed in to change notification settings - Fork 113
E2603: Update View Submissions Page #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CamBhat
wants to merge
15
commits into
expertiza:main
Choose a base branch
from
CamBhat:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3ae1290
Set up view submissions page
CamBhat 8bea696
Merge branch 'expertiza:main' into main
CamBhat 8a68576
Use /submitted_content route for submissions
CamBhat 2fa56e0
Merge pull request #4 from CamBhat/SubmittedContentController
mcarthur-reece 1768932
student view submission implemented, as well as hardcoded url path to…
mcarthur-reece c59e455
changed student submissions page to use view_submissions logic
mcarthur-reece 7e569c7
reworked front end, fixed layout spacing issues
mcarthur-reece c21878f
updated calibration tab api logic, fixed error page when student acce…
mcarthur-reece 3eb923e
Show assignment name in submissions header
CamBhat 8517a14
Merge pull request #5 from CamBhat/front_end_updates
CamBhat 3b9457a
Enable opening/downloading submission artifacts
CamBhat c7b23d0
bug fixes recommended by coderabbit review
mcarthur-reece 977f82c
Merge pull request #6 from CamBhat/front_end_updates
mcarthur-reece f88f738
Refactor tests to use axios_client for submissions
CamBhat 7a43886
Merge branch 'main' of https://github.com/CamBhat/reimplementation-fr…
CamBhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ | |
|
|
||
| # production | ||
| /build | ||
| /dist | ||
|
|
||
| # misc | ||
| .DS_Store | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
ProtectedRoutewrapper creates a security gap.The
assign-gradesroute lacks bothProtectedRouteand aloader. Compare with the new routes at lines 112-121 which properly useProtectedRoute. This inconsistency allows unauthenticated access to theReviewReportPagecomponent for grade assignment.Similarly, the existing routes at lines 103-106 (
viewsubmissions) and 108-111 (submitcontent) under the/edit/path also lackProtectedRoute, creating an inconsistent security posture.🔒 Proposed fix to add protection
{ path: "assignments/:id/assign-grades", - element: <ReviewReportPage />, + element: <ProtectedRoute element={<ReviewReportPage />} leastPrivilegeRole={ROLE.TA} />, + loader: loadAssignment, },📝 Committable suggestion
🤖 Prompt for AI Agents