Add Pathwise Thompson Sampling Acquisition Function#751
Open
Add Pathwise Thompson Sampling Acquisition Function#751
Conversation
Contributor
Author
|
@bertiqwerty: can you review this? Failing tests are due to the botorch version ... |
Contributor
|
Why are all tests failing? Not only against latest botorch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds the pathwise Thompson Sampling ACQF to BoFire which is based on Matheron Samples.
Have you read the Contributing Guidelines on pull requests?
Yes.
Have you updated
CHANGELOG.md?Yes.
Test Plan
Unit tests, currently failing since it is not yet in BoFire main, so we should wait with merging it until it is in BoFire main. But we can review it already before.