-
Notifications
You must be signed in to change notification settings - Fork 46
Feature/ensemble map saas single task gp #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bizbalt
wants to merge
16
commits into
experimental-design:main
Choose a base branch
from
Bizbalt:feature/EnsembleMapSaasSingleTaskGP
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c2c089f
first draft adding EnsambleMapSaasSingleTaskGPSurrogate
jkleinekorte c8ad45c
add surrogate for EnsambleMapSaasSingleTaskGPSurrogate
jkleinekorte 8692714
add data model mapper
jkleinekorte 60c2324
spelling
Bizbalt 0197b5a
map.saas.py changed spelling for ensemble
MichaelRingleb 9d819c5
test comment
MichaelRingleb 8045362
removed comment and added space
MichaelRingleb 78708b9
Merge branch 'feature/EnsembleMapSaasSingleTaskGP' of https://github.…
MichaelRingleb 994ff76
add to innit
Bizbalt cd43ed3
Merge remote-tracking branch 'bofire@bizbalt/feature/EnsembleMapSaasS…
Bizbalt 7c7c04b
Add EnsembleMapSaasSingleTaskGPSurrogate to API and tests
JulianKimmig b8a69db
add test and api
jkleinekorte bfb1bd0
Merge branch 'feature/EnsembleMapSaasSingleTaskGP' of https://github.…
jkleinekorte 405bad0
Ensemble merger to fit bofires expected shape
JulianKimmig 9c7fe04
Merge branch 'feature/EnsembleMapSaasSingleTaskGP' of https://github.…
JulianKimmig 85d8447
remove duplicated assertion
Bizbalt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this docstring does not directly apply to BoFire, more to botorch, keep it concise (https://github.com/experimental-design/bofire/blob/main/bofire/data_models/surrogates/map_saas.py), state the differences to the version that we alread have (see the link) and just list the variables that a user in BoFire can actually choose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One can also link to the docstring from botorch.