Conversation
|
|
||
| ## What can be a constant | ||
|
|
||
| Constants can only hold booleans, numbers, strings, and runes. |
There was a problem hiding this comment.
| Constants can only hold booleans, numbers, strings, and runes. | |
| Constants can only hold Booleans, numbers, strings, and runes. |
There was a problem hiding this comment.
I’d agree since it’s named after a person, but Go uses booleans. We also use it lowercased in our docs (see https://exercism.org/tracks/go/concepts/booleans)
There was a problem hiding this comment.
I think Bethany set me straight on this. Go (and Python) has a bool data type that represents a Boolean value, similar to an int type that represents an integer. There is no "Integer" and there is no "boolean".
There was a problem hiding this comment.
Yep. I’m fine with the change. My thought was that this should also be updated across the track where relevant. That can happen before or after this is merged.
There was a problem hiding this comment.
Definitely. Doing it as a separate PR might be cleaner.
There was a problem hiding this comment.
There's a few differences between the intro and about. I'm not sure if those are intentional. If the two are fairly close, it might be worth making them the same.
There was a problem hiding this comment.
I’d rather have different content for the two files, but the overlap is fairly significant here. We might as well make them the same.
There was a problem hiding this comment.
I'm all for making them different ... where there's a value to that difference, eg omitting some sections from the intro to make it simpler. But if the content is largely the same, there's no reason not to make them entirely the same.
There was a problem hiding this comment.
Agreed. I’ll update the docs Monday.
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Related to #3042