Skip to content

chore: use custom context key type #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buztard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use custom context key type #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tracer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ import (
"go.opentelemetry.io/otel/trace"
)

type contextKey int8

const (
tracerName = "github.com/exaring/otelpgx"
meterName = "github.com/exaring/otelpgx"
startTimeCtxKey = "otelpgxStartTime"
startTimeCtxKey = contextKey(0)
Comment on lines +24 to +29
Copy link
Copy Markdown
Member

@costela costela May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! That makes sense!
However: since we're touching this, it would probably make sense to replace it with a struct{}, so that it uses no memory?

sqlOperationUnknown = "UNKNOWN"
)

Expand Down