Repository navigation
fix: inline nested schema references with annotations - #287
Closed
Kayvan-Zahiri wants to merge 1 commit into
Closed
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nested Pydantic field with
Field(description=...)generates a$refalongside an annotation.InlineJsonSchemaGeneratoronly resolves pure$refobjects, then deletes$defs, leaving a dangling reference in the schema sent byanswer. Titles/examples and additional schema constraints have the same problem.Resolve local references even when siblings are present. Retain the referenced schema and the siblings together using
allOf, including any existing siblingallOfconstraints, so neither side overwrites the other's validation rules. Pure references retain their existing flattened representation.Add six regression cases: four annotation/constraint combinations and public sync/async answer request-body checks. These use dummy keys and mocked request methods. Recursive/unresolvable references and their existing behavior are outside scope; no claim of hosted API acceptance.
Validation on Python 3.12 with the frozen uv environment:
Dependency/version metadata and generated documentation are unchanged. No authenticated Exa calls or paid compute were used. Integration tests requiring a real API key were not run.