Repository navigation
fix: accept list structured monitor run content (#208) - #234
Open
Abhishek21g wants to merge 1 commit into
Open
Abhishek21g wants to merge 1 commit into
Abhishek21g wants to merge 1 commit into
Conversation
…bs#208) outputSchema monitors can return content as a list of objects. Typing was str|dict only, which still fails pydantic validation for list payloads. Extend the union and cover get/list with fixture tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SearchMonitorRunOutput.contentwas typed asstr | dict. When a monitor uses a structuredoutputSchemathat returns a list of objects,SearchMonitorRunsClient.list/getfail pydantic validation.Fixes #208
Note on existing PR
#209 covers the same issue but is merge-conflicting and also bumps package version. This PR is a minimal rebase on current
master: type union + tests only (no version bump). Happy to close this if #209 is preferred after a rebase.Fix
Verify