Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
Updates the DisbursementType enum to use the exact string values returned by the API.
- Changed enum values for STRIPE_CONNECT, PAYPAL_GRANTS, NFG_BATCH_FILE, and MANUAL to match API response.
- Adjusted casing and spacing for human-readable labels.
Comments suppressed due to low confidence (3)
packages/donate-button-v4/src/components/widget/types/Nonprofit.ts:28
- Consider adding a comment to clarify that these enum values directly mirror the API response to avoid confusion about their origin.
STRIPE_CONNECT = 'Stripe',
packages/donate-button-v4/src/components/widget/types/Nonprofit.ts:31
- The value 'manual' is lowercase while the others are capitalized; confirm this matches the API spec or adjust casing for consistency.
MANUAL = 'manual'
packages/donate-button-v4/src/components/widget/types/Nonprofit.ts:27
- Add or update unit tests to cover the new enum values so consumers parsing API responses won’t break if mappings change.
export enum DisbursementType {
santiher
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
DisbursementTypedefinition to match api response