Skip to content

Update DisbursementType#438

Merged
santiher merged 1 commit intomainfrom
ah/update-disbursement-type
Jul 28, 2025
Merged

Update DisbursementType#438
santiher merged 1 commit intomainfrom
ah/update-disbursement-type

Conversation

@Exploding
Copy link
Copy Markdown
Contributor

Updates DisbursementType definition to match api response

Copilot AI review requested due to automatic review settings July 17, 2025 17:16
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
donate-button ✅ Ready (Inspect) Visit Preview Jul 17, 2025 5:16pm

@Exploding Exploding requested a review from santiher July 17, 2025 17:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the DisbursementType enum to use the exact string values returned by the API.

  • Changed enum values for STRIPE_CONNECT, PAYPAL_GRANTS, NFG_BATCH_FILE, and MANUAL to match API response.
  • Adjusted casing and spacing for human-readable labels.
Comments suppressed due to low confidence (3)

packages/donate-button-v4/src/components/widget/types/Nonprofit.ts:28

  • Consider adding a comment to clarify that these enum values directly mirror the API response to avoid confusion about their origin.
	STRIPE_CONNECT = 'Stripe',

packages/donate-button-v4/src/components/widget/types/Nonprofit.ts:31

  • The value 'manual' is lowercase while the others are capitalized; confirm this matches the API spec or adjust casing for consistency.
	MANUAL = 'manual'

packages/donate-button-v4/src/components/widget/types/Nonprofit.ts:27

  • Add or update unit tests to cover the new enum values so consumers parsing API responses won’t break if mappings change.
export enum DisbursementType {

@santiher santiher merged commit 80e34f1 into main Jul 28, 2025
6 checks passed
@santiher santiher deleted the ah/update-disbursement-type branch July 28, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants