Skip to content

fix: resolve argparse conflict for duplicate TypedDict field short flags #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunnySoldier357 merged 2 commits into from
Apr 6, 2026
Merged

fix: resolve argparse conflict for duplicate TypedDict field short flags #442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
761f17e
initial commit
SunnySoldier357 Apr 6, 2026
a2487a3
fix: add comment explaining duplicate short flag guard
SunnySoldier357 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eval_protocol/cli_commands/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,11 @@ def add_args_from_callable_signature(
prefix = name.replace("_", "-")
field_kebab = field_name.replace("_", "-")
flag_name = f"--{prefix}-{field_kebab}"
flags = [flag_name] + aliases.get(f"{name}.{field_name}", []) + [f"--{field_kebab}"]
short_flag = f"--{field_kebab}"
existing = {s for a in parser._actions for s in a.option_strings}
flags = [flag_name] + aliases.get(f"{name}.{field_name}", [])
if short_flag not in existing and short_flag != flag_name:
flags.append(short_flag)
help_text = help_overrides.get(f"{name}.{field_name}", field_help.get(field_name))

_add_flag(parser, flags, field_hints.get(field_name, field_type), help_text)
Expand Down
Loading