-
Notifications
You must be signed in to change notification settings - Fork 29
WIP:gromacs recipe draft with spack 1.x #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kanduri
wants to merge
15
commits into
main
Choose a base branch
from
gromacs2025
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c43c6b2
gromacs recipe draft with spack 1.x
a9744ca
fix schema
simonpintarelli cf0fe9b
add gromacs 2025 to config
simonpintarelli f6a5535
remove duplicate
simonpintarelli 4dedfdc
typo
simonpintarelli 4953f66
Revert "typo"
simonpintarelli 0b0c78b
resolve concretization error
a936cd1
without plumed
c35f88a
update gromacs recipe from older release
5e5ec57
add plumed with groamcs 2022.5
5dd5994
remove old file
3ff9f8e
modified PLUMED recipe with gromacs 2025.0
408c1fb
gromacs with pytorch and plumed
8b51d69
remove unused files
f8d64f9
change uenv name with pytorch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| gcc: | ||
| version: "14.2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| name: gromacs-gh200 | ||
| store: /user-environment | ||
| description: GPU-optimised GROMACS with and without PLUMED, and the toolchain to build your own GROMACS. | ||
| spack: | ||
| repo: https://github.com/spack/spack.git | ||
| commit: releases/v1.0 | ||
| packages: | ||
| repo: https://github.com/spack/spack-packages.git | ||
| commit: releases/v2025.07 | ||
| modules: false | ||
| version: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| gromacs: | ||
| compiler: [gcc] | ||
| network: | ||
| mpi: cray-mpich@8.1.32 +cuda | ||
| unify: when_possible | ||
| specs: | ||
| - cmake | ||
| - cuda@12.9 | ||
| - blas | ||
| - lapack | ||
| - hwloc | ||
| - fftw | ||
| - python@3.12 | ||
| - gromacs@2025.0 +cuda +plumed +mpi +hwloc | ||
| variants: | ||
| - +mpi | ||
| - +cuda | ||
| - cuda_arch=90a | ||
| views: | ||
| develop: | ||
| exclude: ['gromacs'] | ||
| gromacs: | ||
| link: run | ||
| packages: | ||
| - perl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| run: | ||
| features: | ||
| - gromacs | ||
| - cuda | ||
| - mpi | ||
| cc: gcc | ||
| cxx: g++ | ||
| views: | ||
| - gromacs | ||
|
|
||
| build: | ||
| features: | ||
| - gromacs-dev | ||
| - cuda | ||
| - mpi | ||
| cc: gcc | ||
| cxx: g++ | ||
| views: | ||
| - develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| modules: | ||
| # Paths to check when creating modules for all module sets | ||
| prefix_inspections: | ||
| bin: | ||
| - PATH | ||
| lib: | ||
| - LD_LIBRARY_PATH | ||
| lib64: | ||
| - LD_LIBRARY_PATH | ||
|
|
||
| default: | ||
| arch_folder: false | ||
| # Where to install modules | ||
| roots: | ||
| tcl: /user-environment/modules | ||
| tcl: | ||
| all: | ||
| autoload: none | ||
| hash_length: 0 | ||
| exclude_implicits: true | ||
| exclude: [] | ||
| projections: | ||
| all: '{name}/{version}' |
12 changes: 12 additions & 0 deletions
12
recipes/gromacs/2025/gh200-mpi/repo/packages/gromacs/gmxDetectCpu-cmake-3.14.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- a/cmake/gmxDetectCpu.cmake | ||
| +++ b/cmake/gmxDetectCpu.cmake | ||
| @@ -83,7 +83,7 @@ function(gmx_run_cpu_detection TYPE) | ||
| set(GCC_INLINE_ASM_DEFINE "-DGMX_X86_GCC_INLINE_ASM=0") | ||
| endif() | ||
|
|
||
| - set(_compile_definitions "${GCC_INLINE_ASM_DEFINE} -I${PROJECT_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS} -DGMX_TARGET_X86=${GMX_TARGET_X86_VALUE}") | ||
| + set(_compile_definitions ${GCC_INLINE_ASM_DEFINE} -I${PROJECT_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS} -DGMX_TARGET_X86=${GMX_TARGET_X86_VALUE}) | ||
| set(LINK_LIBRARIES "${GMX_STDLIB_LIBRARIES}") | ||
| try_compile(CPU_DETECTION_COMPILED | ||
| "${PROJECT_BINARY_DIR}" | ||
|
|
11 changes: 11 additions & 0 deletions
11
recipes/gromacs/2025/gh200-mpi/repo/packages/gromacs/gmxDetectSimd-cmake-3.14.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- a/cmake/gmxDetectSimd.cmake | ||
| +++ b/cmake/gmxDetectSimd.cmake | ||
| @@ -77,7 +77,7 @@ function(gmx_suggest_simd _suggested_simd) | ||
| else() | ||
| set(GMX_TARGET_X86_VALUE 0) | ||
| endif() | ||
| - set(_compile_definitions "${GCC_INLINE_ASM_DEFINE} -I${CMAKE_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS} -DGMX_TARGET_X86=${GMX_TARGET_X86_VALUE}") | ||
| + set(_compile_definitions ${GCC_INLINE_ASM_DEFINE} -I${CMAKE_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS} -DGMX_TARGET_X86=${GMX_TARGET_X86_VALUE}) | ||
|
|
||
| # Prepare a default suggestion | ||
| set(OUTPUT_SIMD "None") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration contains
modules: false. If that is intended, this file is not necessary.