-
Notifications
You must be signed in to change notification settings - Fork 0
Rip out most usage of VueX #139
Copy link
Copy link
Open
Labels
priority: p3/standardEnhancement with nominal value or bug with nominal impactEnhancement with nominal value or bug with nominal impactsize: mdtype: ergonomicsTooling, refactoring, etcTooling, refactoring, etc
Description
Activity
Metadata
Metadata
Assignees
Labels
priority: p3/standardEnhancement with nominal value or bug with nominal impactEnhancement with nominal value or bug with nominal impactsize: mdtype: ergonomicsTooling, refactoring, etcTooling, refactoring, etc
Type
Projects
- StatusShow more project fieldsTodo
Right now, we use VueX in way more situations than we should. There's this common pattern of delegating a network request to VueX and it stores the response on the state, however in many cases there's no reason why it needs to be in a central state store instead of handling the fetch and response inline (even if we need to access it in a different component, often times its better to just pass the data as a prop), plus it creates room for bugs where old invalid data gets used because it's really tied to the page but is cached across pages (see #138 for an example).