Skip to content

Automated cherry pick of #20840#21572

Open
pjsharath28 wants to merge 1 commit intoetcd-io:release-3.6from
pjsharath28:automated-cherry-pick-of-#20840-upstream-release-3.6
Open

Automated cherry pick of #20840#21572
pjsharath28 wants to merge 1 commit intoetcd-io:release-3.6from
pjsharath28:automated-cherry-pick-of-#20840-upstream-release-3.6

Conversation

@pjsharath28
Copy link
Copy Markdown
Contributor

Cherry pick of #20840 on release-3.6.

#20840: tests: Change max retries when removing a member from a

In CI, the TestGateway and TestMixVersionsSnapshotByAddingMember
are flaky due to the TestMixVersionsSnapshotByAddingMember test
sometimes not closing the second etcd process. This happens if
the second process has not had enough time to become healthy according
to the logic in EtcdServer.mayRemoveMember.

Fix this by retrying member removal for twice the etcdserver.HealthInterval
in EtcdProcessCluster.CloseProc.

Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pjsharath28
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @pjsharath28. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants