http: enforce request body size limit to prevent DoS attacks#21571
http: enforce request body size limit to prevent DoS attacks#21571KambojRajan wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KambojRajan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @KambojRajan. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add request body size enforcement in accessController.ServeHTTP() in server/embed/serve.go, which is the entry point for all HTTP requests before they reach the gRPC-gateway handlers.
Two layers of protection:
Fast-reject via Content-Length: If the declared Content-Length exceeds MaxRequestBytesWithOverhead(), return 413 Request Entity Too Large immediately without reading any body bytes.
Safety net via http.MaxBytesReader: Wraps req.Body so the JSON decoder cannot read past the con