Skip to content

http: enforce request body size limit to prevent DoS attacks#21571

Open
KambojRajan wants to merge 1 commit intoetcd-io:mainfrom
KambojRajan:rk/fix/http-request-body-size-issue
Open

http: enforce request body size limit to prevent DoS attacks#21571
KambojRajan wants to merge 1 commit intoetcd-io:mainfrom
KambojRajan:rk/fix/http-request-body-size-issue

Conversation

@KambojRajan
Copy link
Copy Markdown

Add request body size enforcement in accessController.ServeHTTP() in server/embed/serve.go, which is the entry point for all HTTP requests before they reach the gRPC-gateway handlers.
Two layers of protection:

Fast-reject via Content-Length: If the declared Content-Length exceeds MaxRequestBytesWithOverhead(), return 413 Request Entity Too Large immediately without reading any body bytes.
Safety net via http.MaxBytesReader: Wraps req.Body so the JSON decoder cannot read past the con

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KambojRajan
Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @KambojRajan. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants