add --disable-log-sampling flag for etcdserver#21566
add --disable-log-sampling flag for etcdserver#21566silentred wants to merge 1 commit intoetcd-io:mainfrom
--disable-log-sampling flag for etcdserver#21566Conversation
Signed-off-by: shenmu.wy <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: silentred The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @silentred. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Debug is not meant for production |
Should we provide an option for users to disable log sampling?
While
--log-level=debugoffers comprehensive details, it often floods the logs with excessive output from bbolt, making it unsuitable for production environments. However, the ability to disable log sampling remains crucial for in-depth bug analysis.