Skip to content

add --disable-log-sampling flag for etcdserver#21566

Open
silentred wants to merge 1 commit intoetcd-io:mainfrom
silentred:disable-log-sampling
Open

add --disable-log-sampling flag for etcdserver#21566
silentred wants to merge 1 commit intoetcd-io:mainfrom
silentred:disable-log-sampling

Conversation

@silentred
Copy link
Copy Markdown
Contributor

Should we provide an option for users to disable log sampling?
While --log-level=debug offers comprehensive details, it often floods the logs with excessive output from bbolt, making it unsuitable for production environments. However, the ability to disable log sampling remains crucial for in-depth bug analysis.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: silentred
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @silentred. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Copy Markdown
Member

Debug is not meant for production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants