Skip to content

[WIP] Carry on 21261 #21465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuweid wants to merge 14 commits into
base: main
Choose a base branch
from

*: switch to new protobuf struct

a756d13
Select commit
Loading
Failed to load commit list.
Open

[WIP] Carry on 21261 #21465

*: switch to new protobuf struct
a756d13
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 30, 2026 in 1s

68.36% (-0.11%) compared to 50f4ea2

View this Pull Request on Codecov

68.36% (-0.11%) compared to 50f4ea2

Details

Codecov Report

❌ Patch coverage is 44.14894% with 420 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.36%. Comparing base (50f4ea2) to head (a756d13).
⚠️ Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/printer_fields.go 0.00% 120 Missing ⚠️
etcdctl/ctlv3/command/printer_simple.go 0.00% 86 Missing ⚠️
etcdctl/ctlv3/command/printer.go 0.00% 72 Missing ⚠️
etcdctl/ctlv3/command/printer_json.go 70.00% 18 Missing ⚠️
etcdctl/ctlv3/command/printer_protobuf.go 0.00% 13 Missing ⚠️
client/v3/compare.go 76.74% 7 Missing and 3 partials ⚠️
etcdctl/ctlv3/command/user_command.go 0.00% 8 Missing ⚠️
etcdutl/etcdutl/printer_protobuf.go 0.00% 8 Missing ⚠️
etcdctl/ctlv3/command/watch_command.go 0.00% 7 Missing ⚠️
server/storage/wal/wal.go 70.83% 4 Missing and 3 partials ⚠️
... and 34 more
Additional details and impacted files
Files with missing lines Coverage Δ
api/mvccpb/extension.go 100.00% <100.00%> (ø)
client/v3/concurrency/election.go 79.36% <100.00%> (-2.67%) ⬇️
client/v3/leasing/cache.go 87.42% <100.00%> (-3.69%) ⬇️
client/v3/leasing/kv.go 90.39% <100.00%> (-1.00%) ⬇️
client/v3/leasing/util.go 94.44% <100.00%> (-3.89%) ⬇️
client/v3/mirror/syncer.go 76.74% <100.00%> (ø)
client/v3/namespace/kv.go 73.91% <100.00%> (ø)
client/v3/op.go 77.09% <100.00%> (+1.44%) ⬆️
client/v3/txn.go 100.00% <100.00%> (ø)
etcdutl/snapshot/v3_snapshot.go 58.30% <100.00%> (ø)
... and 68 more

... and 13 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21465      +/-   ##
==========================================
- Coverage   68.47%   68.36%   -0.11%     
==========================================
  Files         428      430       +2     
  Lines       35291    35439     +148     
==========================================
+ Hits        24165    24229      +64     
- Misses       9730     9806      +76     
- Partials     1396     1404       +8

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f4ea2...a756d13. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov