ci: add type tests for TypeScript 5.x to CI workflow#440
Merged
Conversation
JoshuaKGoldberg
approved these changes
Apr 28, 2026
Contributor
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Great!
Shall we also add type tests for TypeScript 7?
IMO yes, as well as TypeScript 6.
Member
I also think adding this to the CI checks would be a good idea, given adoption has grown to around 4.5M per week. |
lumirlumir
approved these changes
Apr 30, 2026
Member
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Please merge this PR if you plan to add a TypeScript v7 CI check in a separate PR. Otherwise, I think including it here could also be a nice option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
add tests in CI
What changes did you make? (Give an overview)
This PR adds type tests for TypeScript v.5.x besides existing tests targeting TypeScript v5.3 and v6.0.
It also enables the TypeScript compiler options
strict,exactOptionalPropertyTypes,verbatimModuleSyntaxanderasableSyntaxOnlyfor all type tests, and disables type checking for JavaScript files compiled or emitted bytscduring the build.These changes align this repo with
eslint/jsonandeslint/markdown.Related Issues
refs eslint/json#230
Is there anything you'd like reviewers to focus on?
Question: Shall we also add type tests for TypeScript 7? It's still in the beta prerelease, but there was already a regression reported in #425 for an issue that only occurs in TypeScript 7. @eslint/eslint-team