Skip to content

ci: add type tests for TypeScript 5.x to CI workflow#440

Merged
fasttime merged 2 commits intomainfrom
ts-5.x-type-tests
Apr 30, 2026
Merged

ci: add type tests for TypeScript 5.x to CI workflow#440
fasttime merged 2 commits intomainfrom
ts-5.x-type-tests

Conversation

@fasttime
Copy link
Copy Markdown
Member

@fasttime fasttime commented Apr 26, 2026

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

add tests in CI

What changes did you make? (Give an overview)

This PR adds type tests for TypeScript v.5.x besides existing tests targeting TypeScript v5.3 and v6.0.

It also enables the TypeScript compiler options strict, exactOptionalPropertyTypes, verbatimModuleSyntax and erasableSyntaxOnly for all type tests, and disables type checking for JavaScript files compiled or emitted by tsc during the build.

These changes align this repo with eslint/json and eslint/markdown.

Related Issues

refs eslint/json#230

Is there anything you'd like reviewers to focus on?

Question: Shall we also add type tests for TypeScript 7? It's still in the beta prerelease, but there was already a regression reported in #425 for an issue that only occurs in TypeScript 7. @eslint/eslint-team

@fasttime fasttime marked this pull request as ready for review April 28, 2026 10:32
Copy link
Copy Markdown
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Shall we also add type tests for TypeScript 7?

IMO yes, as well as TypeScript 6.

@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Apr 30, 2026
@lumirlumir
Copy link
Copy Markdown
Member

Shall we also add type tests for TypeScript 7? It's still in the beta prerelease, but there was already a regression reported in #425 for an issue that only occurs in TypeScript 7.

I also think adding this to the CI checks would be a good idea, given adoption has grown to around 4.5M per week.

Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Please merge this PR if you plan to add a TypeScript v7 CI check in a separate PR. Otherwise, I think including it here could also be a nice option.

@lumirlumir lumirlumir moved this from Implementing to Merge Candidates in Triage Apr 30, 2026
@fasttime fasttime merged commit be8981f into main Apr 30, 2026
32 checks passed
@fasttime fasttime deleted the ts-5.x-type-tests branch April 30, 2026 12:01
@github-project-automation github-project-automation Bot moved this from Merge Candidates to Complete in Triage Apr 30, 2026
@fasttime fasttime mentioned this pull request Apr 30, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants