Skip to content

ci: add type tests for TypeScript 5.x to CI workflow #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lumirlumir merged 4 commits into from
Apr 21, 2026
Merged

ci: add type tests for TypeScript 5.x to CI workflow #230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46eb06b
ci: add type tests for TypeScript 5.x to CI workflow
fasttime Apr 14, 2026
23528b0
Update tests/types/tsconfig.dist.json
fasttime Apr 18, 2026
b66b898
add npm scripts
fasttime Apr 20, 2026
2ddcba8
apply suggestions from code review
fasttime Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ jobs:
run: npm install
- name: Check Types
run: npm run test:types
- name: Check Types (TypeScript 5.3)
run: npx -p typescript@5.3 -y -- tsc -p tests/types/tsconfig.dist.json
- name: Check Types (TypeScript 5.x)
run: npx -p typescript@5.x -y -- tsc -p tests/types/tsconfig.dist.json
Comment thread
lumirlumir marked this conversation as resolved.
Outdated
Comment thread
lumirlumir marked this conversation as resolved.
Outdated
are_the_types_wrong:
name: Are the types wrong?
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,9 @@ export default defineConfig([
{
name: "json/jsonc",
plugins: { json },
files: ["**/*.jsonc"],
files: ["**/*.jsonc", "**/tsconfig*.json"],
language: "json/jsonc",
languageOptions: { allowTrailingCommas: true },
extends: ["json/recommended"],
},
{
Expand Down
16 changes: 16 additions & 0 deletions tests/types/tsconfig.dist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"checkJs": false, // The JSDoc @import tag used in JS files is not supported in TypeScript < 5.5.
"noEmit": true,
"rootDir": "../..",
"strict": true,
"strictNullChecks": true,
"useUnknownInCatchVariables": true,
"exactOptionalPropertyTypes": true,
"verbatimModuleSyntax": true
// "erasableSyntaxOnly" is not supported in TypeScript < 5.8.
},
"files": [],
"include": ["../../dist"]
Comment thread
lumirlumir marked this conversation as resolved.
Outdated
Comment thread
lumirlumir marked this conversation as resolved.
Outdated
}
Loading