Fix/torch review feedback#55
Open
sasso-effe wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes problems created by #54.
Fixes:
from ._core import *doesn't re-export dunder names. Fixedpython/polyhedral_gravity/__init__.pyto explicitly re-import__version__,__parallelization__,__commit__, and__logging__from_core. Verifiedpolyhedral_gravity.__version__etc. work again at the package level.python/polyhedral_gravity/torch.pyandtest/python/test_gravity_model_torch.pyto be PEP 8 compliant, and checked them using ruff. I also changed variables; names that, even if PEP 8 compliant, were too obscure.docs/quickstart/examples_python.rstanddocs/api/python.rst, with links to notebooks. Also, I made the PyTorch Interface mention inREADME.mdmore concise.script/measure_runtime.pyon the pre-PR baseline (d71c8f8) vs. this branch:evaluate, 2000×1 ptevaluate, 1×2000 ptsGravityEvaluable, 2000×1 ptGravityEvaluable, 1×2000 ptsAll differences are within run-to-run noise.