Remove function SimdHogDirectionHistograms - #951
Merged
Conversation
Drop the C API, C++ wrapper, Base/SSE4.1/AVX2/AVX-512BW/NEON/SVE2 implementations, helper AddRowToHistograms, and related tests. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
The helper lived beside HogDirectionHistograms but is still used by HogFeatureExtractor. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
September 9, 2026 09:48
HogTailMask, HogDifferenceLo, and HogDifferenceHi lived beside HogDirectionHistograms but are still required by HogFeatureExtractor. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated
SimdHogDirectionHistogramsand its C++ wrapperSimd::HogDirectionHistograms.Changes
SimdLib.h/SimdLib.cpp.SimdLib.hpp.AddRowToHistograms.HogExtractFeatures,HogDeinterleave,HogFilterSeparable) and their*Hog.cpptranslation units.CovertDifferenceand SVE2HogTailMask/HogDifferenceLo/HogDifferenceHi, which are still used byHogExtractFeatures.HogDirectionHistogramsauto-tests fromTestHog.cpp/Test.cpp.docs/2026.html.Python wrapper / VS2022
SimdHogDirectionHistograms, sopy/SimdPyis unchanged.prj/vs2022project files are unchanged because Hog source files still contain the remaining Hog functions and tests.Testing
Release CMake build with g++ (
-DSIMD_SHARED=ON):nm -D libSimd.soexportsSimdHogDeinterleave,SimdHogExtractFeatures,SimdHogFilterSeparableonly../Test "-r=.." -fi=Hog -tt=1 -ts=1passed (remaining Hog tests)../Test "-r=.." -fi=HogDirectionHistogramsreports no matching tests.python3 ./Test.py -r=.. -i Hogand-i Sobelcompleted successfully.SimdSve2Hog.cppandSimdNeonHog.cppsucceeded after restoring the SVE2 helpers.