-remove function SimdSynetConvolution8i. - #1016
Merged
Merged
Conversation
Drop the C API (Init, ExternalBufferSize, InternalBufferSize, Info, SetParams, Forward), C++ wrapper Simd::SynetConvolution8i, Base/SSE4.1/AVX2/AVX-512BW/AVX-512VNNI/AMX-BF16/NEON/SVE2 implementations, and related tests. SimdSynetConvolution8iCommon.h stays because quantized convolution still uses it. The Python wrapper does not expose this function. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
September 25, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the C API (
SimdSynetConvolution8iInit,SimdSynetConvolution8iExternalBufferSize,SimdSynetConvolution8iInternalBufferSize,SimdSynetConvolution8iInfo,SimdSynetConvolution8iSetParams,SimdSynetConvolution8iForward), the C++ wrapperSimd::SynetConvolution8i, Base/SSE4.1/AVX2/AVX-512BW/AVX-512VNNI/AMX-BF16/NEON/SVE2 implementations, and related tests.SimdSynetConvolution8iCommon.hstays because quantized convolution still uses its shared helpers. The Python wrapper does not expose this function.Release notes for 7.2.166 in
docs/2026.htmllist the removed API, tests, and descriptions. Visual Studio 2022 projects are updated to match.Verification
libSimd.so,Test).nm -D libSimd.sohas noConvolution8iexports../Test -r=.. -cc=1 -fi=Sobel -tt=1 -ts=1(C++ API check plus Sobel) finished successfully../Test -r=.. -fi=SynetQuantizedConvolutionForward -tt=1 -ts=1finished successfully.python3 ./Test.py -r=.. -i Sobelfinished successfully.