Refactor SSE4.1 AddFeatureDifference to unaligned loads and stores - #1015
Merged
ermig1979 merged 1 commit intoSep 25, 2026
Merged
Conversation
Remove alignment checks and use unaligned SSE4.1 load and store intrinsics directly. Co-authored-by: Ihar Yermalayeu <ermig1979@gmail.com>
ermig1979
marked this pull request as ready for review
September 25, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
Sse41::AddFeatureDifferenceinsrc/Simd/SimdSse41AddFeatureDifference.cppto match the recent SSE4.1 unaligned-access style:_mm_loadu_si128and_mm_storeu_si128directly, instead ofLoad<align>()/Store<align>().Test plan
SIMD_SHARED=ON, AVX-512 and AMX disabled, SSE4.1 and AVX2 enabled)../Test "-r=.." -fi=AddFeatureDifference -tt=1 -ts=1frombuild/. All tests finished successfully. Base, SSE4.1, and AVX2 results matched.