Remove function SimdSynetInnerProduct8i - #1008
Merged
Merged
Conversation
Drop the C API, Base/SSE4.1/AVX2/AVX-512BW/NEON/SVE2 implementations, and related tests. The Python wrapper does not expose this function. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
September 23, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
SimdSynetInnerProduct8iand every platform implementation, along with the tests that covered it.SimdLib.h/SimdLib.cppand the compatibility-type reference to it.Simd*SynetInnerProduct8i.cppsources.SynetInnerProduct8itests and the Visual Studio 2022 project entries for the deleted sources.docs/2026.html(API, tests, and description).py/SimdPy/Simd.py) does not expose this function, so it is unchanged.Test plan
SIMD_SHARED=ON, AVX-512VNNI, AMX-BF16). Build finished with exit code 0../Test "-r=.." -fi=SynetInnerProduct -tt=1 -ts=1.SynetInnerProduct32fForward,SynetInnerProductLayerForward, andSynetInnerProduct16bForwardpassed.SynetInnerProduct8iis no longer registered.libSimd.soandTestexport noInnerProduct8isymbol.