Skip to content

Stop redirect loops #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avtobiff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop redirect loops #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/yaws_server.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2704,8 +2704,11 @@ deliver_redirect_map(CliSock, Req, Arg,
%% Here Code is 1xx, 2xx, 4xx or 5xx
?Debug("in redir ~p", [Code]),
deliver_xxx(CliSock, Req, Arg, Code);
deliver_redirect_map(_CliSock, _Req, Arg,
{_Prefix, Code, Path, Mode}, N) when is_list(Path) ->
deliver_redirect_map(_CliSock, #http_request{path = {abs_path, ReqPath}}, Arg,
{Prefix, Code, Path, Mode}, N)
when is_list(Path) andalso
%% Stop redirect loops
ReqPath /= Prefix ->
%% Here Code is 1xx, 2xx, 4xx or 5xx
?Debug("in redir ~p", [Code]),
Path1 = if
Expand All @@ -2725,8 +2728,13 @@ deliver_redirect_map(_CliSock, _Req, Arg,
put(yaws_arg, Arg),
put(client_data_pos, N),
{page, {[{status, Code}], Page}};
deliver_redirect_map(CliSock, Req, Arg,
{_Prefix, Code, URL, Mode}, N) when is_record(URL, url) ->
deliver_redirect_map(CliSock,
#http_request{path = {abs_path, ReqPath}} = Req, Arg,
{Prefix, Code, URL, Mode}, N)
when is_record(URL, url)
andalso
%% Stop redirect loops
ReqPath == Prefix ->
%% Here Code is 3xx
?Debug("in redir ~p", [Code]),
H = get(outh),
Expand Down