fix: use grouped apps endpoint on initial load, fall back to per-namespace polling#580
Merged
Merged
Conversation
… back to namesspace based polling. Increase polling time to lessen the load on the Epinio server):
Merged
6 tasks
…b.com:epinio/ui into fix/initial-load-performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Fixes the initial app list page performance issue where one API call was fired per namespace on load.
Pairs with epinio/epinio#3034.
Occurred changes and/or fixed issues
findGroupedAppsstore action that calls the new/api/v1/applications/groupedendpointonMountednow usesfindGroupedAppsfor the initial load (1 call, server-side fan-out) instead of per-namespace callsfindAppsInNamespaceaction unchangedTechnical notes summary
The grouped endpoint returns
map[namespace]PaginatedResponse. The store action guards againstepiniofyinjecting non-namespace keys into the response map before classifying items.Areas or cases that should be tested
Areas which could experience regressions