fix(bounties): use close events for solver attribution#1305
Open
JSONbored wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClosedEvent.closerinstead of inferring attribution from PR cross-reference candidates.closedAtvalue and only attribute merged PR closers targeting the same repository.What changed
CLOSED_EVENTtimeline entries and the associated PR closer fields.closedAt, non-completed events, wrong-repo PR closers, and thecheck_github_issue_closedintegration path.Why
Cross-reference entries describe PR text references, not necessarily the PR that caused the issue's current closure. Bounty voting should follow GitHub's close-event source of truth so validators do not attribute a completed bounty to stale or unrelated closing references.
Validation
uv run pytest tests/utils/test_github_api_tools.py tests/validator/test_issue_competitions_forward.py -quv run ruff check gittensor/utils/github_api_tools.py tests/utils/test_github_api_tools.pyuv run ruff format --check gittensor/utils/github_api_tools.py tests/utils/test_github_api_tools.pyuv run pyright gittensor/utils/github_api_tools.py tests/utils/test_github_api_tools.pysolver_lookup_failed=False.