fix(installation): case-insensitive repo removal and normalize PK#127
Open
Yurii214 wants to merge 1 commit into
Open
fix(installation): case-insensitive repo removal and normalize PK#127Yurii214 wants to merge 1 commit into
Yurii214 wants to merge 1 commit into
Conversation
…trius#120) Centralize repo full-name validation/normalization and use lowercase canonical keys on webhook insert paths. Removal events now clear rows via case-insensitive match and log when no row is updated. Fixes entrius#120 Co-authored-by: Cursor <cursoragent@cursor.com>
Yurii214
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120
Summary
normalizeRepoFullName()/validateRepoFullName()utilityinstallation_repositories.addedstores lowercase canonical PKinstallation_repositories.removedclears rows case-insensitivelyWhy
GitHub repo identity is case-insensitive, but PostgreSQL PK lookups are not.
Admin registration could create
owner/repowhile webhooks storedOwner/Repo,so uninstall events returned HTTP 202 while leaving
registered=true.Test plan
npm run lintpassesnpm run buildpasses