Tweak plugin types - #20
Merged
Merged
Conversation
alyst
force-pushed
the
tweak_plugin_types
branch
from
July 13, 2025 00:41
6c2fa72 to
201e72c
Compare
ensko
requested changes
Jul 15, 2025
ensko
left a comment
ensko
left a comment
Owner
There was a problem hiding this comment.
Looks mostly good! I got a different binary when compiling the plugin. It's probably just a compiler version mismatch, but are you using the command from the Justfile?
Just to make sure it's --release.
I will probably re-compile the WASM anyway once I merge, since it feels better to have this binary blob in my package compiled myself, but still wanted to make sure.
to match the wrapped Hayagriva type more closely it also resolves the ambiguity of the `prefix` field
alyst
force-pushed
the
tweak_plugin_types
branch
from
July 16, 2025 04:01
201e72c to
7fd98ed
Compare
Contributor
Author
|
@SillyFreak Thank you, I've addressed your comments, and the tests are passing now! |
Owner
|
Thanks a lot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subset of #18 that renames Alexandria's
Entrytype (a wrapper around Hayagriva'sBibliographyItem) toReferenceto make it more obvious that it is an element of the Alexandria's bibliography.references listand renames its fields to match the field of the wrapped Hayagriva's type, where the corresponding values are taken from.
In particular, it addresses the ambiguity of the
prefixfield (which wraps theBibliographyItem.first_field) -- it is not the Alexandria's own bibliography prefix.