Improve tooling#6
Open
mihaiberq wants to merge 6 commits into
Open
Conversation
nem035
reviewed
Nov 14, 2018
| jest/no-focused-test: 0 | ||
| jest/no-identical-title: 2 | ||
| jest/valid-expect: 2 | ||
| node/no-unsupported-features/es-syntax: 0 |
Member
There was a problem hiding this comment.
You can fix this one by adding to package.json:
"engines": {
"node": "8.10.0"
},
Author
There was a problem hiding this comment.
I added it but eslint seemed to ignore it, so i left the rule
Author
There was a problem hiding this comment.
Imo this should be ok, since they the rule is included in the engines field anyway
nem035
reviewed
Nov 14, 2018
| jest/no-identical-title: 2 | ||
| jest/valid-expect: 2 | ||
| node/no-unsupported-features/es-syntax: 0 | ||
| no-unused-vars: 1 |
Member
There was a problem hiding this comment.
Try using on, off, and warn instead of the numbers cause it's more readable
nem035
reviewed
Nov 14, 2018
| "redux-mock-store": "^1.3.0", | ||
| "redux-object-to-promise": "^0.3.3", | ||
| "redux-optimist-promise": "^0.8.3" | ||
| "redux-optimist-promise": "^0.8.3", |
Author
There was a problem hiding this comment.
redux-optimist-promise also provides us with another
metakey that can be used to revert optimistic updates in case of a server request failure.
Member
There was a problem hiding this comment.
Hmmm i don't think reduck is using this, I think it's only because of the tests
mihaiberq
force-pushed
the
improve-tooling
branch
from
bf53f56 to
415c329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.