Skip to content

Changes to support MATRIX execution - #87

Closed
liorko87 wants to merge 9 commits into
encryptogroup:publicfrom
cryptobiu:public
Closed

Changes to support MATRIX execution#87
liorko87 wants to merge 9 commits into
encryptogroup:publicfrom
cryptobiu:public

Conversation

@liorko87

Copy link
Copy Markdown

Hi,

In order to support MATRIX The following changes was done:

  • Support for gcc < 8
  • Remove relative paths from .gitmodules
  • Add MATRIX directory

@lenerd

lenerd commented Aug 29, 2018

Copy link
Copy Markdown
Collaborator

Hi,
I noticed that in 11c4986 you sometimes used the macro _GNUC_ and on other times __GNUC_. The GCC documentation, however, defines __GNUC__ (double underscores on both sides).

Also, I guess this may break build with clang (when experimental header/symbols are removed), since they define __GNUC__ to the value 4.

@liorko87

liorko87 commented Sep 4, 2018

Copy link
Copy Markdown
Author

As for the macro, I suggest that we follow the documentation and use __GNUC__.
As for clang, maybe we can check

#ifdef __GNUC__
     #ifndef __clang__

@dd23 dd23 mentioned this pull request Sep 24, 2018
@lenerd lenerd mentioned this pull request Oct 2, 2018
4 tasks
@lenerd

lenerd commented Oct 12, 2018

Copy link
Copy Markdown
Collaborator

I close this in favor of #94.

@lenerd lenerd closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants