🐛 fix: ensure events only fire when public methods return valid data#215
Open
DerAndereAndi wants to merge 1 commit intodevfrom
Open
🐛 fix: ensure events only fire when public methods return valid data#215DerAndereAndi wants to merge 1 commit intodevfrom
DerAndereAndi wants to merge 1 commit intodevfrom
Conversation
Member
DerAndereAndi
commented
Apr 16, 2026
DerAndereAndi
commented
- Fix DeviceConfiguration OR/AND precedence bug in CheckEventPayloadDataForFilter (item.KeyId match was OR'd with item.Value != nil instead of AND'd, causing the filter to accept any keyvalue item with a value regardless of KeyId)
- Gate 11 event handlers across EG LPC, MA MGCP, and MA MPC on a successful public-method call so event notifications stay consistent with the data consumers can actually retrieve via the public API
- Update event tests accordingly
- Fix DeviceConfiguration OR/AND precedence bug in CheckEventPayloadDataForFilter (item.KeyId match was OR'd with item.Value != nil instead of AND'd, causing the filter to accept any keyvalue item with a value regardless of KeyId) - Gate 11 event handlers across EG LPC, MA MGCP, and MA MPC on a successful public-method call so event notifications stay consistent with the data consumers can actually retrieve via the public API - Update event tests accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.