Revert LPP Failsafe values back to positive values in the examples#214
Merged
sthelen-enqs merged 1 commit intoApr 15, 2026
Merged
Conversation
Per the spec, the values are always >= 0 because their name already indicates the production direction Only the APPL value itself (the LoadLimit.Value in SetProductionLimit and WriteProductionLimit) remains <= 0 (-10000 in HEMS, -100 in controlbox), since that's the SignDependentAbsValueLimit where sign matters.
Contributor
|
LGTM, thanks |
sthelen-enqs
added
documentation
sthelen-enqs
deleted the
188-update-controlboxhems-examples-positive_failsafe_limits
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the spec, the values are always >= 0 because their name already indicates the production direction Only the APPL value itself (the LoadLimit.Value in SetProductionLimit and WriteProductionLimit) remains <= 0 (-10000 in HEMS, -100 in controlbox), since that's the SignDependentAbsValueLimit where sign matters.