Skip to content

Update the Hardware Plugin Config section of the README #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abetomo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update the Hardware Plugin Config section of the README #2

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a0273
Update the Hardware Plugin Config section of the README
abetomo Oct 9, 2025
c06905f
Patch port numbers for consistency
thomasonzhou Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ Please note that running multiple instances of the website will cause conflictin

### Hardware Plugin Config

The hardware plugin is specified in `openarm_description/openarm.ros2_control.xacro` as follows:
The hardware plugin is specified in `openarm_description/urdf/ros2_control/openarm.ros2_control.xacro` as follows:

```xml
<ros2_control name="openarm_system" type="system">
<ros2_control name="openarm_hardware_interface" type="system">
<hardware>
<plugin>openarm_mujoco_hardware/MujocoHardware</plugin>
<param name="prefix">left_</param>
Expand All @@ -41,3 +41,27 @@ The hardware plugin is specified in `openarm_description/openarm.ros2_control.xa
```

When using OpenArm in a bimanual configuration, the WebSocket ports default to 1337 for right arm and 1338 for left arm commands. However, in practice commands can be sent and states can be received through any connected port.

Configuration example in `urdf/ros2_control/openarm.bimanual.ros2_control.xacro`:

```xml
<!-- Left Arm Hardware Interface -->
<ros2_control name="openarm_left_hardware_interface" type="system">
<hardware>
<plugin>openarm_mujoco_hardware/MujocoHardware</plugin>
<param name="prefix">left_</param>
<param name="websocket_port">1337</param>
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WebSocket port assignments appear to be swapped based on the explanation in line 43. The text states 'ports default to 1337 for right arm and 1338 for left arm', but the configuration shows left arm using 1337 and right arm using 1338.

Copilot uses AI. Check for mistakes.
</hardware>
<!-- Joint configurations -->
</ros2_control>

<!-- Right Arm Hardware Interface -->
<ros2_control name="openarm_right_hardware_interface" type="system">
<hardware>
<plugin>openarm_mujoco_hardware/MujocoHardware</plugin>
<param name="prefix">right_</param>
<param name="websocket_port">1338</param>
Comment thread
thomasonzhou marked this conversation as resolved.
Outdated
</hardware>
<!-- Joint configurations -->
</ros2_control>
```