Feature/v2.0 li#52
Draft
tokirobot wants to merge 10 commits into
Draft
Conversation
tokirobot
force-pushed
the
feature/v2.0_li
branch
from
8a6920d to
3c2056c
Compare
abetomo
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
This file appears to be empty. Is it required, or can it be removed?
Contributor
There was a problem hiding this comment.
This file appears to be empty. Is it required, or can it be removed?
abetomo
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
The same image is also located at assets/robot/openarm_v2.0/imgs/*.
Since these look like explanatory images, could we keep the ones under docs/ and remove the ones under assets/?
abetomo
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
Why is pyproject.toml needed here?
abetomo
reviewed
May 15, 2026
| <joint name="openarm_${left_arm_prefix}finger_joint2"> | ||
| <param name="mimic">openarm_${left_arm_prefix}finger_joint1</param> | ||
| <param name="multiplier">${left_finger_mimic_multiplier}</param> | ||
| <command_interface name="position"/> |
Contributor
There was a problem hiding this comment.
Jazzy throws the following error, so is it ok to remove this line?
[ros2_control_node-2] terminate called after throwing an instance of 'std::runtime_error'
[ros2_control_node-2] what(): Joint 'openarm_left_finger_joint2' has mimic attribute not set to false: Activated mimic joints cannot have command interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
TODO