Skip to content

Add parsing of control gains for hand #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Apr 29, 2026
+16 −0
Merged

Add parsing of control gains for hand #51

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38db886
added parsing of control gains for hand
TJMolnar Apr 17, 2026
325b175
changed kph/kdh to kp_hand/kd_hand for clarity
TJMolnar Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/arm/v10/control_gains.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ joint6:
joint7:
kp: 10.0
kd: 0.5

hand:
kp: 5.0
kd: 0.1
4 changes: 4 additions & 0 deletions urdf/ros2_control/openarm.ros2_control.xacro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
<param name="kd5">${control_gains['joint5']['kd']}</param>
<param name="kd6">${control_gains['joint6']['kd']}</param>
<param name="kd7">${control_gains['joint7']['kd']}</param>
<xacro:if value="${hand}">
<param name="kph">${control_gains['hand']['kp']}</param>
Copy link
Copy Markdown
Contributor

@abetomo abetomo Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kph is not immediately obvious, so would kp_hand be a clearer name?

Copy link
Copy Markdown
Contributor Author

@TJMolnar TJMolnar Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, changed as requested.

<param name="kdh">${control_gains['hand']['kd']}</param>
</xacro:if>
</xacro:if>
</hardware>

Expand Down