Skip to content

Smartly Apply Constraints During Cartesian Product#773

Merged
Scienfitz merged 31 commits intomainfrom
feature/smart_cartesian_product_constraints
May 5, 2026
Merged

Smartly Apply Constraints During Cartesian Product#773
Scienfitz merged 31 commits intomainfrom
feature/smart_cartesian_product_constraints

Conversation

@Scienfitz
Copy link
Copy Markdown
Collaborator

@Scienfitz Scienfitz commented Mar 31, 2026

This PR implements a more optimized Cartesian product creation in the presence of constraints which can result in memory and time gains of many orders of magnitude (see mini benchmark below).

Rationale

  • Currently constraint filtering is done only after the entire search space has been created. This means the memory needed for the intermediate df is potentially huge even if the final df is tiny. In practice this had led to many problems when working with slot based mixtures, even if the optimized from_simplex constructor was used
  • Instead, any given cosntraint can be applied early during the parameter-by-parameter cross join operations. There are three tiers of applying this:
    1. As soon as possible filter: A constraint can be applied as soon as all of its affected parameters are in the current crossjoin-df. After this application the constraint is fully ensured and does not have to be applied again. If the order in which cross join goes over the parameters is optimized this would already lead to an improvement as subsequent operations "see" much smaller left-dataframes.
    2. Partial/early filter:
    • Some constraints can be applied even if not all affected parameters are present yet.
    • Example: no label duplicates - even if there are just 2 out of 7 parameters present, we can remove the rows that have duplicates in the 2 parameters.
    • This filter has to be repeated in every loop iteration until it ran with all affected parameters present. However, the cost of multiple filter applications are dwarfed by the savings from smaller cross join operations.
    • Whether a constraint supports early filtering might depend on its configuration, example: exclude constraint with combiner (early filter supported for OR, not for AND or XOR)
    1. Look ahead: Some constraints can look ahead based on the possible parameter values that might be incoming and recognize that constraints cannot be fulfilled even in future crossjoin iterations.
    • This is essentially what from_simplex implements for the very special case of 1 global sum constraint and 1 cardinality constraint. If we ever implement look-ahead filters for all constraints the from_simplex constructor might become obsolete
    • For this we would need access to the parameter values inside the constraint logic, which might be easier to implement once the constraints have been refactored Refactor General Constraint Interface #517
  • This PR implements smart filtering for tiers 1 and 2. I left IMPROVE notes to remember about tier 3. To achieve this
    • Constraint.get_invalid was extended to handle situations where not all parameters are in the df to be filtered. The constraint can the decide whether it can apply early filtering or returns the new UnsupportedEarlyFilteringError if it needs all parameters present
    • The crossjoin is done in a custom loop inside parameter_cartesian_prod_pandas_constrained which itself performs the process described above after deciding on a smart parameter order for the crossjoin

Good To Know

  • new Constraint method has_polars_implementation, discussion here
  • new Constraint property _filtering_parameters, discussion here
  • strange appearance of DiscreteNoLabelDuplicatesConstraint in DiscretePermutationInvarianceConstraint .get_invalid explained here

Mini Benchmark:

  • Scenario 1: 7 categoricals with 8 values each and a no label dupe constraint
  • Scenario 2: complex slot-based mixture with 4 slots, 2 subgroups, sum constraints and additional product parameters
  • Scenario 3: like scenario 2 but with 6 slots and 3 subgroups
  • tested on (old main vs this branch) x (polars on/off)
  • 30min as max runtime for a quick test
Scenario Polars main feature Speedup Memory reduction
1: from_product, 7×8 cat, NoLabelDuplicates (2M→40K rows) OFF 61.4s / 636 MB 6.6s / 48 MB 9.3x 13.2x
ON 1.8s / 73 MB 1.6s / 47 MB 1.1x 1.6x
2: from_simplex, 4-slot mixture + 3 extras (~4.5M→2.4K rows) OFF 14.7s / 62MB 0.09s / 1.5 MB 163x 41x
ON 14.8s / 62MB 0.53s / 7.3 MB 28x 8.5x
3: from_simplex, 6-slot mixture + 3 extras (~12B→22K rows) OFF >30min 0.5s / 17 MB >3600x
ON >30min 0.5s / 17 MB >3600x

@Scienfitz Scienfitz self-assigned this Mar 31, 2026
@Scienfitz Scienfitz added the enhancement Expand / change existing functionality label Mar 31, 2026
@Scienfitz Scienfitz added this to the 0.15.0 milestone Mar 31, 2026
@Scienfitz Scienfitz force-pushed the feature/smart_cartesian_product_constraints branch 2 times, most recently from 6a33c52 to 503fef9 Compare April 1, 2026 23:48
Comment thread baybe/constraints/base.py Outdated
Comment thread baybe/constraints/base.py Outdated
Comment thread baybe/constraints/discrete.py
@Scienfitz Scienfitz marked this pull request as ready for review April 2, 2026 00:27
Copilot AI review requested due to automatic review settings April 2, 2026 00:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes discrete search space construction by applying discrete constraints incrementally during Cartesian product generation (including improved Polars/Pandas interop), aiming to reduce intermediate memory use and runtime for highly constrained spaces.

Changes:

  • Added baybe.searchspace.utils with shared Cartesian product helpers and a new incremental constrained-product builder.
  • Extended discrete constraint interfaces to support (or explicitly refuse) early filtering via UnsupportedEarlyFilteringError, plus a has_polars_implementation capability flag.
  • Updated discrete search space constructors and tests to use the new incremental filtering path (and added parity tests vs the naive approach).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
baybe/searchspace/utils.py New utilities: parameter ordering, pandas/polars cartesian product, and incremental constrained cartesian product builder.
baybe/searchspace/discrete.py Switches discrete space construction to incremental filtering; Polars path builds partial product and merges remainder via pandas. Adds new from_simplex validation.
baybe/constraints/base.py Adds _required_filtering_parameters and has_polars_implementation; updates docs for partial-dataframe filtering semantics.
baybe/constraints/discrete.py Updates discrete constraints to support early/partial filtering and to raise UnsupportedEarlyFilteringError when unsupported.
baybe/exceptions.py Adds UnsupportedEarlyFilteringError.
tests/constraints/test_constrained_cartesian_product.py New test ensuring naive vs incremental constrained product results match across several scenarios.
tests/constraints/test_constraints_polars.py Updates imports for moved cartesian product helpers.
tests/test_searchspace.py Updates imports for moved cartesian product helpers.
tests/hypothesis_strategies/alternative_creation/test_searchspace.py Adjusts simplex-related tests to reflect new from_simplex constraints.
CHANGELOG.md Documents incremental filtering and new constraint capability/exception additions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread baybe/searchspace/utils.py
Comment thread baybe/searchspace/utils.py Outdated
Comment thread baybe/searchspace/discrete.py Outdated
Comment thread baybe/constraints/discrete.py Outdated
Comment thread baybe/constraints/discrete.py Outdated
Comment thread CHANGELOG.md Outdated
Comment thread tests/constraints/test_constrained_cartesian_product.py
Copy link
Copy Markdown
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Scienfitz, I'll need some more time for the review but wanted to already share some comments so that you can start to think about it / we can discuss. More will follow 🙃

Comment thread baybe/searchspace/utils.py
Comment thread baybe/constraints/base.py Outdated
Comment thread baybe/constraints/base.py Outdated
Comment thread baybe/constraints/base.py Outdated
Comment thread baybe/constraints/discrete.py Outdated
Comment thread baybe/constraints/discrete.py Outdated
Comment thread baybe/constraints/discrete.py Outdated
Comment thread baybe/constraints/discrete.py Outdated
Comment thread baybe/exceptions.py
Comment thread baybe/constraints/discrete.py Outdated
@Scienfitz Scienfitz force-pushed the feature/smart_cartesian_product_constraints branch 2 times, most recently from 78eb87b to 66c39c4 Compare April 9, 2026 18:16
Copy link
Copy Markdown
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete review. Only had a look at the changes made to the constraints so far. Tried to comprehend the constraints, and the logic for them seems to check out. Will give a more in-depth review after some of the general issues pointed out by the others have been addressed.

Comment thread CHANGELOG.md Outdated
Comment thread baybe/exceptions.py
Comment thread baybe/constraints/discrete.py Outdated
@Scienfitz Scienfitz force-pushed the feature/smart_cartesian_product_constraints branch from 66c39c4 to 2c634b5 Compare April 10, 2026 20:29
Comment thread baybe/searchspace/discrete.py
Comment thread baybe/searchspace/discrete.py Outdated
Comment thread baybe/searchspace/discrete.py Outdated
Comment thread baybe/searchspace/discrete.py Outdated
Comment thread baybe/searchspace/utils.py Outdated
Comment thread baybe/searchspace/utils.py Outdated
Comment thread baybe/searchspace/utils.py Outdated
Comment thread baybe/searchspace/utils.py Outdated
@Scienfitz Scienfitz force-pushed the feature/smart_cartesian_product_constraints branch from de9f44b to 744ecf9 Compare April 24, 2026 18:50
Copy link
Copy Markdown
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close to approve, only need a bit more time to check the last remaining parts

Comment thread baybe/constraints/base.py Outdated
Comment thread baybe/constraints/base.py Outdated
Copy link
Copy Markdown
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool feature, I do not see any major issue, anything open is already addressed.

Comment thread baybe/searchspace/utils.py Outdated
Comment thread tests/constraints/test_constrained_cartesian_product.py
Comment thread baybe/searchspace/utils.py
@Scienfitz Scienfitz force-pushed the feature/smart_cartesian_product_constraints branch from fb1bd63 to f7e84f1 Compare April 29, 2026 23:04
Scienfitz and others added 25 commits May 5, 2026 16:52
Co-authored-by: AdrianSosic <adrian.sosic@merckgroup.com>
Co-authored-by: AdrianSosic <adrian.sosic@merckgroup.com>
Separates concerns using a dedicted subclass-specific Boolean check
@Scienfitz Scienfitz force-pushed the feature/smart_cartesian_product_constraints branch from cb0d194 to 765c0bc Compare May 5, 2026 14:53
@Scienfitz
Copy link
Copy Markdown
Collaborator Author

Scienfitz commented May 5, 2026

posting for later reference

Mini Benchmark:

  • Scenario 1: 7 categoricals with 8 values each and a no label dupe constraint
  • Scenario 2: complex slot-based mixture with 4 slots, 2 subgroups, sum constraints and 3 additional product parameters
  • Scenario 3: like scenario 2 but with 6 slots and 3 subgroups, more values per parameter
  • tested on (old main vs this branch) x (polars on/off)
  • 30min as max runtime for a quick test
Scenario Polars main feature Speedup Memory reduction
1: from_product, 7×8 cat, NoLabelDuplicates (2M→40K rows) OFF 61.4s / 636 MB 6.6s / 48 MB 9.3x 13.2x
ON 1.8s / 73 MB 1.6s / 47 MB 1.1x 1.6x
2: from_simplex, 4-slot mixture + 3 extras (~4.5M→2.4K rows) OFF 14.7s / 62MB 0.09s / 1.5 MB 163x 41x
ON 14.8s / 62MB 0.53s / 7.3 MB 28x 8.5x
3: from_simplex, 6-slot mixture + 3 extras (~12B→22K rows) OFF >30min 0.5s / 17 MB >3600x
ON >30min 0.5s / 17 MB >3600x

@Scienfitz Scienfitz merged commit 9944e61 into main May 5, 2026
13 checks passed
@Scienfitz Scienfitz deleted the feature/smart_cartesian_product_constraints branch May 5, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Expand / change existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants