Conversation
There was a problem hiding this comment.
Pull request overview
Adds AGENTS.md guidance files intended to be injected into agentic tooling context to steer code, tests, docs, and examples toward existing BayBE conventions.
Changes:
- Introduce root-level AI-agent coding guide (
AGENTS.md) covering architecture, typing, imports, CI, and workflow. - Add test-suite conventions for pytest structure/fixtures/parametrization (
tests/AGENTS.md). - Add docs and examples conventions for Sphinx/MyST and runnable scripts (
docs/AGENTS.md,examples/AGENTS.md).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
AGENTS.md |
Project-wide agent guidance for BayBE coding patterns, tooling, and PR workflow |
tests/AGENTS.md |
Conventions for writing/organizing pytest tests and fixtures |
docs/AGENTS.md |
Conventions for Sphinx/MyST docs authoring and syntax |
examples/AGENTS.md |
Conventions for executable examples and CI smoke-test behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey, nice work on the recent updates -- the fail-fast language in sections 2/8/16 reads well, and the admonition rewrite is much clearer. I've been reviewing this alongside how I structure similar files in my repos and wanted to share a few thoughts. Happy to help implement any of these if useful, but also easy for you to pick up directly since they're mostly structural. CLAUDE.md + symlinks: Have you considered making the canonical file To keep other tools working, symlink from the root: Single source of truth, three consumers. The subdirectory files ( Complementary content from
I'm not suggesting replacing your work -- the AGENTS.md has valuable depth (validation patterns, deprecation strategy, the naming table, fixture architecture) that the Anti-pattern specificity: As m-aebrer mentioned, rules like "prefer local fixtures" are easier for agents to comply with when there's a concrete example. Even a one-liner showing the preferred pattern would help. Let me know if any of this is useful -- happy to put together changes on a separate branch or contribute directly here, whichever you'd prefer. |
Scienfitz
left a comment
There was a problem hiding this comment.
@LeanAndMean many thanks for the input. I'm turning your coment into several threads because otherwise it will be nearly impossible to converse about thes eeveral sub-suggestions made therein, feel free to comment in the respective threads
|
also +1 to @LeanAndMean's point about CLAUDE.md vs AGENTS.md. I have my harness |
AdrianSosic
left a comment
There was a problem hiding this comment.
I think my approach for reviewing this PR is simply a pragmatic one: test it and adjust where necessary =) I have very little motivation to read agent-created files meant for agents only, so let's me instead point out problems / express wishes as they emerge.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
To comply with agent instruction.
48fb106 to
137544b
Compare
AVHopp
left a comment
There was a problem hiding this comment.
ONly one small suggestion to add a paragraph describing how we prefer examples to look like, other than that I'd say let's see how well this workd
Co-authored-by: Alexander V. Hopp <[email protected]>
AGENTS.mdfiles contain content intended for agentic operators. They are recognized by most coding frameworks (most importantlyclaudeandopencode) and are injected into the context whenever an agent reads a folder where such a file is contained. They lead to more consistent code being generated and generally more in line with what has already been done without explicitly having to state this over and over again.The content here is meant as a start and not as complete. We can continue to add rules as we evolve.
The content has been produced in the following manner: