Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
instead of a single tuple (needed for interpoint constraints)

### Fixed
- `ContinuousCardinalityConstraint` now works in hybrid search spaces
- Typo in `_FixedNumericalContinuousParameter` where `is_numeric` was used
instead of `is_numerical`
- `SHAPInsight` breaking with `numpy>=2.4` due to no longer accepted implicit array to
scalar conversion

Expand Down
8 changes: 7 additions & 1 deletion baybe/constraints/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import numpy as np
import pandas as pd

from baybe.constraints.continuous import ContinuousCardinalityConstraint
from baybe.parameters.utils import is_inactive
from baybe.searchspace import SubspaceContinuous

Expand All @@ -25,7 +26,12 @@ def is_cardinality_fulfilled(
Returns:
``True`` if all cardinality constraints are fulfilled, ``False`` otherwise.
"""
for c in subspace_continuous.constraints_cardinality:
cardinality_constraints = [
c
for c in subspace_continuous.constraints_subspace_generating
if isinstance(c, ContinuousCardinalityConstraint)
]
for c in cardinality_constraints:
# Get the activity thresholds for all parameters
cols = df[c.parameters]
thresholds = {
Expand Down
2 changes: 1 addition & 1 deletion baybe/parameters/numerical.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def summary(self) -> dict:
class _FixedNumericalContinuousParameter(ContinuousParameter):
"""Parameter class for fixed numerical parameters."""

is_numeric: ClassVar[bool] = True
is_numerical: ClassVar[bool] = True
# See base class.

value: float = field(converter=float)
Expand Down
Loading
Loading