Skip to content

Adaptive hyper-prior: CHENKernelFactory#752

Merged
AdrianSosic merged 13 commits into
emdgroup:dev/gpfrom
emiliencgm:chen_prior
Apr 27, 2026
Merged

Adaptive hyper-prior: CHENKernelFactory#752
AdrianSosic merged 13 commits into
emdgroup:dev/gpfrom
emiliencgm:chen_prior

Conversation

@emiliencgm
Copy link
Copy Markdown
Collaborator

@emiliencgm emiliencgm commented Feb 26, 2026

DevPR, parent is #745

Add an adaptive hyper-prior for GP proposed in the paper:
Guanming Chen, Maximilian Fleck, Thijs Stuyver. Leveraging Hidden-Space Representations Effectively in Bayesian Optimization for Experiment Design through Dimension-Aware Hyperpriors. ChemRxiv. 09 February 2026.
DOI: https://doi.org/10.26434/chemrxiv.10001986/v2

image

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 26, 2026

CLA assistant check
All committers have signed the CLA.

@AdrianSosic
Copy link
Copy Markdown
Collaborator

Hi @emiliencgm, thanks for the commit ⭐ I'll take care of finalizing the PR once the necessary preparations in my dev branch are completed. Will ping you, @maxfleck and @tstuyver here once it's ready for you to review 🙃

@emiliencgm
Copy link
Copy Markdown
Collaborator Author

emiliencgm commented Mar 2, 2026 via email

@AdrianSosic AdrianSosic added the dev label Mar 2, 2026
@AdrianSosic
Copy link
Copy Markdown
Collaborator

Hi @emiliencgm, thanks for the commit ⭐ I'll take care of finalizing the PR once the necessary preparations in my dev branch are completed. Will ping you, @maxfleck and @tstuyver here once it's ready for you to review 🙃

Will have to wait until I'm back from holidays 😬

@AdrianSosic AdrianSosic force-pushed the chen_prior branch 2 times, most recently from 5505ba8 to c01b540 Compare April 2, 2026 12:42
@AdrianSosic AdrianSosic force-pushed the chen_prior branch 3 times, most recently from affc25d to 2398672 Compare April 17, 2026 10:29
@AdrianSosic AdrianSosic marked this pull request as ready for review April 24, 2026 08:33
Copilot AI review requested due to automatic review settings April 24, 2026 08:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Gaussian process preset implementing the adaptive kernel hyper-prior from Chen et al. (2026), and updates documentation/citations to support the new preset and reference handling.

Changes:

  • Introduces CHEN GP preset and CHENKernelFactory implementing the adaptive hyper-prior kernel configuration.
  • Adds/updates bibliographic references and relocates the rendered bibliography to a dedicated docs page.
  • Updates existing EDBO preset docstrings to cite Shields et al. (2021) and updates changelog/contributors accordingly.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
docs/userguide/transfer_learning.md Removes per-page bibliography block (bibliography now centralized).
docs/references.bib Adds BibTeX entries for Chen (2026) and Shields (2021).
docs/misc/references.md New references page rendering the bibliography.
docs/index.md Adds “References” to the docs navigation.
baybe/surrogates/gaussian_process/presets/edbo_smoothed.py Updates citations in docstrings (and adjusts docstring formatting).
baybe/surrogates/gaussian_process/presets/edbo.py Updates citations and reference text in docstrings.
baybe/surrogates/gaussian_process/presets/core.py Adds CHEN to the GaussianProcessPreset enum with citation.
baybe/surrogates/gaussian_process/presets/chen.py New CHEN kernel factory implementing the adaptive hyper-prior.
baybe/surrogates/gaussian_process/presets/init.py Exposes CHENKernelFactory from the presets package.
CONTRIBUTORS.md Adds contributors for the Chen hyper-prior work.
CHANGELOG.md Notes availability of the new CHEN preset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread baybe/surrogates/gaussian_process/presets/edbo_smoothed.py
Comment thread baybe/surrogates/gaussian_process/presets/edbo_smoothed.py
Comment thread baybe/surrogates/gaussian_process/presets/chen.py
Comment thread baybe/surrogates/gaussian_process/presets/edbo.py
Comment thread baybe/surrogates/gaussian_process/presets/edbo.py
Comment thread CONTRIBUTORS.md Outdated
@AdrianSosic
Copy link
Copy Markdown
Collaborator

@emiliencgm @tstuyver @maxfleck

It took a little longer for me to finalize the PR because it turned out there were quite some architectural changes and decisions to be made first. If you are interested, you can follow up on the latest developments (and how your PR fits into these) here: #745

Note: what will probably still change in your code is the way how TaskParameters are handled, but I'll take care of this in a follow-up PR – the current version of the code is good for merge from my perspective. Right now, TaskParameters are circumvented using a selection mechanism, but I'm planning to add some machinery that allows us to outsource their handling to other BayBE default mechanisms. But this is just FYI.

Again: I'm glad that your work eventually finds its way into our package! I've also added a recent simulation result to the PR description which shows the immediate benefits! ⭐

@AdrianSosic AdrianSosic requested review from maxscheurer and removed request for maxscheurer April 24, 2026 10:34
@AdrianSosic
Copy link
Copy Markdown
Collaborator

@emiliencgm @tstuyver @maxfleck

I've sent a collaboration invite for this repo to you. Once you've accepted, I can add you as reviewers

Copy link
Copy Markdown
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

@AdrianSosic AdrianSosic requested a review from maxfleck April 24, 2026 13:09
@AdrianSosic
Copy link
Copy Markdown
Collaborator

@maxfleck: you are now a reviewer
@emiliencgm: just noticed that this is actually your PR, so you're automatically involved in the reviewing process =)
@tstuyver: invite pending

Comment thread baybe/surrogates/gaussian_process/presets/chen.py Outdated
Comment thread baybe/surrogates/gaussian_process/presets/edbo.py
Comment thread docs/references.bib
@AdrianSosic AdrianSosic requested a review from tstuyver April 27, 2026 09:00
Comment thread CHANGELOG.md
Copy link
Copy Markdown
Collaborator

@maxfleck maxfleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.
I also like that you are linking the original EDBO paper. It took me quit a while in the beginning of our project to figure out that EDBO != EDBO+ (hyperprior-wise).

@AdrianSosic AdrianSosic merged commit f1e7a0b into emdgroup:dev/gp Apr 27, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev new feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants