Add inverted and shifted hartmann benchmark#674
Merged
Conversation
Hrovatin
requested review from
AVHopp,
AdrianSosic and
Scienfitz
as code owners
kalama-ai
reviewed
Oct 22, 2025
Hrovatin
commented
Oct 24, 2025
AVHopp
reviewed
Oct 24, 2025
AVHopp
reviewed
Oct 27, 2025
AVHopp
reviewed
Oct 27, 2025
AVHopp
reviewed
Oct 29, 2025
Collaborator
AVHopp
left a comment
AVHopp
left a comment
There was a problem hiding this comment.
Like the way this is going! Have some more ideas for further simplification
Scienfitz
requested changes
Nov 6, 2025
AVHopp
reviewed
Jan 7, 2026
Collaborator
AVHopp
left a comment
AVHopp
left a comment
There was a problem hiding this comment.
Some comments related to parts of the design that I still do not fully agree with resp. understand
Scienfitz
requested changes
Jan 23, 2026
Collaborator
|
@Hrovatin any movement in this PR or should we close it? |
Collaborator
Author
|
@Scienfitz still on my todo list to add your last two comments |
Scienfitz
requested changes
Mar 31, 2026
Hrovatin
force-pushed
the
benchmark/shifted
branch
from
9efb03a to
2547819
Compare
Scienfitz
approved these changes
Mar 31, 2026
Collaborator
Scienfitz
left a comment
Scienfitz
left a comment
There was a problem hiding this comment.
lgtm, last comments but otherwise ready for merge
Scienfitz
reviewed
Apr 8, 2026
AVHopp
reviewed
Apr 9, 2026
Collaborator
AVHopp
left a comment
AVHopp
left a comment
There was a problem hiding this comment.
LGTM, only one general question and need a bit more time before I can approve
AVHopp
approved these changes
Apr 9, 2026
Collaborator
AVHopp
left a comment
AVHopp
left a comment
There was a problem hiding this comment.
Some minor comments on the docstrings and type hints. Other than that, everything is either flagged by the CI (type error in mypy) or opened as a comment.
Scienfitz
force-pushed
the
benchmark/shifted
branch
from
229cd22 to
c500e7b
Compare
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Updated the docstring to clarify that the callable now shifts both dimensions and bounds for the Hartmann function.
Co-authored-by: Alexander V. Hopp <[email protected]>
Scienfitz
force-pushed
the
benchmark/shifted
branch
from
c500e7b to
6b451d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new TL benchmarks:
@kalama-ai