Update Twitter Icon to New Icon

[nitesh2920]

Description:

The current Twitter icon is outdated. We need to replace it with the new Twitter icon to keep the website looking modern.

Expected Result:

The Twitter icon should be updated to reflect the latest icon.

I would like to work on this issue. please assign it to me!

[nitesh2920]

Could this issue be labeled for Hacktoberfest 2024, @jaredgalanis and @marcoow? I would like to work on it.

[NullVoxPopuli]

This whole repo is participating in hacktoberfest via to topic on the project home page 🎉

[nitesh2920]

This whole repo is participating in hacktoberfest via to topic on the project home page 🎉

so I can directly raise a PR ?

[NullVoxPopuli]

Yes, thank you! 🎉

[mansona]

for the record this change would need to happen on ember-styleguide: https://github.com/ember-learn/ember-styleguide/blob/master/addon/constants/es-footer.js#L3-L8

[nitesh2920]

@mansona so i need to raise a PR on that repo ?

[mansona]

yes that's correct

[nitesh2920]

I have one query @mansona we can also update the svg of twitter logo class here then also the problem will solved.

[mansona]

well yes we could update the content of the twitter logo class but I would probably rename twitter-logo to x-logo and you can update the content 👍

You can also update the lines that I linked to 👍

[nitesh2920]

@mansona, I understand your point. I will make the required changes and raise a PR.

[nitesh2920]

I have one question how can I see changes this in my local machine? I can't figure it out. Should I only need to run the test cases? @mansona

[nitesh2920]

@mansona raise a PR here please review it

[BornDeleuze]

From my understanding it seems like this involves changes in two repos: there is the styleguide issue, with this PR from @nitesh2920 , and then updating the usage of twitter on this website, so that it imports from the styleguide properly. Without updating this site I think the twitter logos will just be broken, and will not update to X.

I made a PR for this which replaces twitter usage with x, 1168. I think with these two PRs the twitter logos and references will be updated correctly.