[BUGFIX] ensure CSS instructions work out the box#188
Open
billybonks wants to merge 1 commit intoember-cli:mainfrom
Open
[BUGFIX] ensure CSS instructions work out the box#188billybonks wants to merge 1 commit intoember-cli:mainfrom
billybonks wants to merge 1 commit intoember-cli:mainfrom
Conversation
Since Vite became the default, if you follow the instructions for plain CSS and create multiple CSS files they will not be compiled properly this is because according to embroider spec the CSS file should have an import statement in order for the compilation to occur properly https://embroider-build.github.io/embroider/docs/spec.html see under CSS header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Vite became the default, if you follow the instructions for plain CSS and create multiple CSS files they will not be compiled properly
this is because according to embroider spec the CSS file should have an import statement in order for the compilation to occur properly
https://embroider-build.github.io/embroider/docs/spec.html see under CSS header
Initial research done here embroider-build/embroider#2657