Require explicit catalog refs

[eloylp]

Summary

• require explicit public ids when creating new prompt, skill, and guardrail catalog rows
• preserve no-id updates only when the same-scope/name row already exists
• update REST, MCP, UI forms, docs, and fixtures for explicit catalog refs

Verification

• go test ./internal/mcp
• go test ./internal/store ./internal/daemon ./internal/mcp ./internal/workflow ./internal/selfimprovement ./internal/scheduler ./internal/webhook
• npm test (internal/ui)
• npm run build (internal/ui)
• go test ./...

Closes #725

[eloylp]

PR Review — pr-reviewer

Verdict: APPROVE

Findings

• None.

Summary

The PR satisfies #725: new prompt/skill/guardrail create/import paths now require explicit public refs, existing same-scope/name no-id updates preserve refs, and REST/MCP/UI surfaces document and enforce the new requirement.

Verification: go test ./internal/store ./internal/daemon ./internal/mcp

[eloylp]

Blocking finding:

config.example.yaml still defines all prompts: entries without id, but this PR now rejects new prompt imports without explicit ids. Seeding an empty daemon with the documented example will fail on the first prompt, e.g. store import: prompt "scout-issues" requires explicit id.

Please add id: to each prompt entry in config.example.yaml, and update the short example comment near the top of that file so the shipped import template remains valid under the new contract.

[eloylp]

PR Review — pr-reviewer

Verdict: REQUEST_CHANGES

Findings

• [blocking] config.example.yaml:9 — Issue Require explicit public refs for new intelligence catalog assets #725 requires import documentation/templates to enforce explicit public refs, and the maintainer specifically asked for id: on each prompt entry in config.example.yaml. The PR branch still shows the short example and all concrete prompts: entries without id, so importing the shipped empty-daemon template will still fail under the new validation contract.

Summary

The code direction is still sound, but the documented example config remains invalid for new prompt imports.

[eloylp]

Addressed the blocking feedback by adding explicit id: values to every prompt entry in config.example.yaml and updating the short import-format snippet at the top to show the required prompt ref.

Verification: go test ./...

[eloylp]

PR Review — pr-reviewer

Verdict: APPROVE

Findings

• None.

Summary

The updated PR satisfies issue #725, including the shipped config.example.yaml import template: the short prompt example and every concrete prompt entry now include explicit stable id: values, while the create/import paths still preserve existing same-scope/name refs for compatibility.

Verification: go test ./...; GitHub check test passed on dcba3d0ed56e99c7addde2f6824d7d6f5154f530.